Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugins] Apply --skip-files also to destination of symlinks #3767

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[plugins] Apply --skip-files also to destination of symlinks #3767

merged 1 commit into from
Sep 3, 2024

Conversation

pmoravec
Copy link
Contributor

Resolves: #3767

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@packit-as-a-service Packit-as-a-Service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3767
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor Author

Reproducer:

mkdir /opt/topsecret
echo "my secret" > /opt/topsecret/secretfile
ln -s /etc/systemd/system/secret  /opt/topsecret/secretfile
sos report --batch --build -o systemd --skip-files="/opt/topsecret/*"

Then, collected sosreport still has:

# file /var/tmp/sosreport-pmoravec-rhel9-2024-08-30-iwucpyj/etc/systemd/system/secret 
/var/tmp/sosreport-pmoravec-rhel9-2024-08-30-iwucpyj/etc/systemd/system/secret: symbolic link to ../../../opt/topsecret/secretfile
# file /var/tmp/sosreport-pmoravec-rhel9-2024-08-30-iwucpyj/opt/topsecret/secretfile 
/var/tmp/sosreport-pmoravec-rhel9-2024-08-30-iwucpyj/opt/topsecret/secretfile: ASCII text
# cat /var/tmp/sosreport-pmoravec-rhel9-2024-08-30-iwucpyj/opt/topsecret/secretfile 
Fri Aug 30 03:57:34 PM CEST 2024
#

@TurboTurtle TurboTurtle merged commit cc88008 into sosreport:main Sep 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcastill jcastill jcastill approved these changes

@TurboTurtle TurboTurtle TurboTurtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmoravec @TurboTurtle @jcastill